Skip to content

fix(upstream): look up unmodeled scoring drift by fingerprint, not capped list - #1903

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
joaovictor91123:fix/unmodeled-drift-fingerprint-lookup
Jun 30, 2026
Merged

fix(upstream): look up unmodeled scoring drift by fingerprint, not capped list#1903
JSONbored merged 2 commits into
JSONbored:mainfrom
joaovictor91123:fix/unmodeled-drift-fingerprint-lookup

Conversation

@joaovictor91123

@joaovictor91123 joaovictor91123 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add getUpstreamDriftReportByFingerprint so drift sync can load a report by its stable fingerprint regardless of status.
  • Switch syncUnmodeledScoringConstantDrift from scanning listUpstreamDriftReports(env, 50) to the fingerprint-keyed lookup, preventing duplicate open reports, lost issue metadata, and resolve no-ops when the row ages out of the recency window.
  • Add regression coverage that ages the unmodeled-constants report past the newest-50 list and verifies update + resolve still hit the same row.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Issue creation is currently blocked for contributor accounts on the upstream repo; this is a focused correctness fix with regression tests.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥97% coverage of the lines AND branches you changed (aim for 98%+ on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Full npm run test:ci runs in GitHub Actions; targeted vitest covered the new regression suite.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — backend drift-sync logic only.

Notes

Made with Cursor

@joaovictor91123 @cursoragent
fix(upstream): look up unmodeled scoring drift by fingerprint, not ca…
003095f 
…pped list

syncUnmodeledScoringConstantDrift scanned only the newest 50 drift reports,
so an older unmodeled-constants row could be missed (duplicate opens, lost
issue metadata, resolve no-ops). Query by the stable fingerprint directly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dosubot dosubot Bot added the size:S label Jun 30, 2026
@loopover-orb

loopover-orb Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-06-30 22:27:45 UTC

3 files · 1 AI reviewer · no blockers · readiness 66/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
The change correctly replaces a capped recency scan with a fingerprint-keyed repository lookup, which matches the table's unique fingerprint constraint and preserves existing row metadata when the report has aged out of the newest-50 list. The regression test exercises both update and resolve paths against an aged row, so the visible fix is targeted and coherent with the PR description. I do not see a reachable correctness break in the provided diff.

Nits — 3 non-blocking
  • nit: test/unit/unmodeled-scoring-drift.test.ts:132 uses generated timestamps with hours 24 through 50, which keeps lexical ordering but makes the fixture data invalid ISO datetimes and less representative of production rows.
  • test/unit/unmodeled-scoring-drift.test.ts:132 should generate valid increasing timestamps, for example by adding minutes/hours from a base Date and serializing with toISOString(), so the regression stays faithful to the ISO timestamps stored by production code.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:S; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR; address the blocker before review.
Contributor workload ✅ 10/10 Author activity: 48 registered-repo PR(s), 31 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor joaovictor91123; Gittensor profile; 48 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: joaovictor91123
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 48 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Fix the blocker.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 30, 2026
@joaovictor91123 @cursoragent
test(upstream): prove aged-out drift lookup without bumping updatedAt…
0521be6 
… first

updateUpstreamDriftReportIssue rewrites updatedAt, which put the row back
inside listUpstreamDriftReports(50) and invalidated the regression. Seed
issue metadata on upsert and re-age only after the update sync under test.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dosubot dosubot Bot added the lgtm label Jun 30, 2026
@JSONbored
JSONbored merged commit b53f249 into JSONbored:main Jun 30, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 30, 2026
@RenzoMXD RenzoMXD mentioned this pull request Jul 1, 2026
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSONbored JSONbored JSONbored approved these changes

Assignees

@joaovictor91123 joaovictor91123

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
gittensory - v1 roadmap
Status: Done

Milestone

M3.5 — Agent Layer Phase 2 (maintaine...

Development

Successfully merging this pull request may close these issues.

2 participants

@joaovictor91123 @JSONbored